Code Review

Looping statements

?

if (dayNow > 7) {
    System.out.println("Please enter number 1-7");
}
if (dayNow < 1) {
    System.out.println("Please enter number 1-7");
}
if (dayNow == 2) {
    System.out.println("Tuesday");
}
if (dayNow == 3) {
    System.out.println("Wednesday");
}
if  (dayNow == 4) {
    System.out.println("Thursday");
}
if (dayNow == 5) {
    System.out.println("Friday");
}
if (dayNow == 6) {
    System.out.println("Saturday");
}
if (dayNow == 7) {
    System.out.println("Sunday");
}

?

public static void main(String... args) {
    int hour = 22;
    if (hour >= 12) {
        if (hour <= 16) {
            System.out.println("Good day");
        }
    }
    if (hour >= 4) {
        if (hour <= 11) {
            System.out.println("Good morning");
        }
    }
    if (hour >= 16) {
        if (hour < 24) {
            System.out.println("Good evening");
        } else {
            System.out.println("Good night");
        }
    }
}

?

public static void main(String[] args) {
    int n;
    Scanner in = new Scanner(System.in);
    System.out.println("Введите число:" );
    n = Integer.parseInt(in.nextLine());
    if (n >= 6 && n <= 12) {
        System.out.println("Доброе утро!");
    } else if (n >= 13 && n <= 18) {
        System.out.println("Добрый день!");
    } else if (n >= 19 && n <= 23) {
        System.out.println("Добрый вечер!");
    } else if ((n >= 1) && (n <= 5) || (n == 24)) {
        System.out.println("Доброй ночи!");
    } else {
        System.out.println("Некорректный время!");
    }
}

?

?

if (day == 1) {
    System.out.println("Today is Monday!");
} else if(day == 2) {
    System.out.println("Today is Tuesday!");
} else if(day == 3) {
    System.out.println("Today is Wednesday!");
} else if(day == 4) {
    System.out.println("Today is Thursday!");
} else if(day == 5) {
    System.out.println("Today is Friday!");
} else if(day == 6) {
    System.out.println("Today is Saturday!");
} else if(day == 7) {
    System.out.println("Today is Sunday!");
}

?

public static void main(String[] args) {
    int hour = 13;
    switch(hour){
        case 1:
            System.out.println("Good night!");
            break;
        case 2:
            System.out.println("Good night!");
            break;
        case 3:
            System.out.println("Good night!");
            break;
        case 4:
            System.out.println("Good night!!");
            break;
        case 5:
            System.out.println("Good night!");
            break;
        case 6:
            System.out.println("Good morning!");
            break;
        case 7:
            System.out.println("Good morning!");
            break;
        case 8:
            System.out.println("Good morning!");
            break;
        case 9:
            System.out.println("Good morning!");
            break;
        case 10:
            System.out.println("Good morning!");
            break;
        case 11:
            System.out.println("Good morning!");
            break;
        case 12:
            System.out.println("Good day!");
            break;
        case 13:
            System.out.println("Good day!");
            break;
        case 14:
            System.out.println("Good day!");
            break;
        case 15:
            System.out.println("Good day!");
            break;
        case 16:
            System.out.println("Good day!");
            break;
        case 17:
            System.out.println("Good day!");
            break;
        case 18:
            System.out.println("Good evening!");
            break;
        case 19:
            System.out.println("Good evening!");
            break;
        case 20:
            System.out.println("Good evening!");
            break;
        case 21:
            System.out.println("Good evening!");
            break;
        case 22:
            System.out.println("Good night!");
            break;
        case 23:
            System.out.println("Good night!");
            break;
        case 0:
            System.out.println("Good night!");
            break;
    }
}

?

public static void taskNumberOne(int dayNumber) {
    switch (dayNumber) {
        case 1 -> System.out.printf("%s - is %s\n", dayNumber, WeekDays.SUNDAY.getWeekDay());
        case 2 -> System.out.printf("%s - is %s\n", dayNumber, WeekDays.MONDAY.getWeekDay());
        case 3 -> System.out.printf("%s - is %s\n", dayNumber, WeekDays.TUESDAY.getWeekDay());
        case 4 -> System.out.printf("%s - is %s\n", dayNumber, WeekDays.WEDNESDAY.getWeekDay());
        case 5 -> System.out.printf("%s - is %s\n", dayNumber, WeekDays.THURSDAY.getWeekDay());
        case 6 -> System.out.printf("%s - is %s\n", dayNumber, WeekDays.FRIDAY.getWeekDay());
        case 7 -> System.out.printf("%s - is %s\n", dayNumber, WeekDays.SATURDAY.getWeekDay());
        default -> System.out.println("Week day is not valid");
    }
}

?

public class Lesson03task2 {
    public static void main(String[] args) {
        int dayOfTheWeek = 11;
        if (dayOfTheWeek == 1) {
            System.out.printf("%d - is Sunday.%n", dayOfTheWeek);
        } else if (dayOfTheWeek == 2) {
            System.out.printf("%d - is Monday.%n", dayOfTheWeek);
        } else if (dayOfTheWeek == 3) {
            System.out.printf("%d - is Tuesday.%n", dayOfTheWeek);
        } else if (dayOfTheWeek == 4) {
            System.out.printf("%d - is Wednesday.%n", dayOfTheWeek);
        } else if (dayOfTheWeek == 5) {
            System.out.printf("%d - is Thursday.%n", dayOfTheWeek);
        } else if (dayOfTheWeek == 6) {
            System.out.printf("%d - is Friday.%n", dayOfTheWeek);
        } else if (dayOfTheWeek == 7) {
            System.out.printf("%d - is Saturday.%n", dayOfTheWeek);
        } else {
            System.out.printf("%d - there is no such day of the week.%n",
                    dayOfTheWeek);
        }
    }
}

?

public class Lesson03task3 {
    public static void main(String[] args) {
        int hour = 11;
        if (hour >= 0 && hour < 6) {
            System.out.printf("%d - доброй ночи.", hour);
        } else if (hour >=6 && hour < 12) {
            System.out.printf("%d - доброе утро.", hour);
        } else if (hour >=12 && hour < 18) {
            System.out.printf("%d - добрый день.", hour);
        } else if (hour >=18 && hour < 24) {
            System.out.printf("%d - добрый вечер.", hour);
        } else if (hour == 24) {
            System.out.printf("%d - доброй ночи.", hour);
        } else {
            System.out.printf("%d - такого часа в сутках нет.", hour);
        }
    }
}

?

public static void main(String[] args) {
        int time = 5;
        if ((time == 24) || ( time >= 1 && time < 6)) {
            System.out.println("Доброй ночи");
        } else if (time >= 6 && time < 12) {
            System.out.println("Доброе утро");
        } else if (time >= 12 && time < 18) {
            System.out.println("Добрый день");
        } else if (time >= 18 && time < 24) {
            System.out.println("Добрый вечер");
        } else {
            System.out.println("ошибка");
        }
    }

?

public class Lesson3Task4 {
    public static void main(String[] args) {
        int currentHour = 14;
        switch (currentHour) {
            case 10:
                System.out.println("Доброе утро!");
                break;
            case 14:
                System.out.println("Добрый день!");
                break;
            case 19:
                System.out.println("Добрый вечер!");
                break;
            case 3:
                System.out.println("Доброй ночи!");
                break;
        }
    }
}

?

public class Task04 {
    public static void main(String[] args) {
        Scanner scanner = new Scanner(System.in);
        System.out.println("Put the time");
        int time = scanner.nextInt();
        switch (time) {
            case 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11:
                System.out.printf("When the time is %s, then- Good Morning", time);
                break;
            case 12, 13, 14, 15, 16:
                System.out.printf("When the time is %s, then- Good afternoon", time);
                break;
            case 17, 18, 19, 20:
                System.out.printf("When the time is %s, then- Good evening", time);
                break;
            case 21, 22, 23, 24:
                System.out.printf("When the time is %s, then- Good night", time);
                break;
            default:
                System.out.println("Put the right time number");
        }
    }
}

?

static boolean isTopPlayer(int sizeTop, int positionPlayerByDamage) {
    if (positionPlayerByDamage <= sizeTop) {
        return true;
    } else {
        return false;
    }
}

?

static String getDayOfWeekNumber(byte dayOfWeekNumber) {
    String day = " ";
    switch(dayOfWeekNumber) {
        case 1:
            day = "MONDAY";
            break;
        case 2:
            day = "TUESDAY";
            break;
        case 3:
            day = "WEDNESDAY";
            break;
        case 4:
            day = "THURSDAY";
            break;
        case 5:
            day = "FRIDAY";
            break;
        case 6:
            day = "SATURDAY";
            break;
        case 7:
            day = "SUNDAY";
            break;
        default:  return null;
    } return day;
}

?

static String getResult(int tanksKilledFirstPlayer, int tanksKilledSecondPlayer) {
    int pointFirst = tanksKilledFirstPlayer * KILL_POINT;
    int pointSecond = tanksKilledSecondPlayer * KILL_POINT;
    if (tanksKilledFirstPlayer > tanksKilledSecondPlayer) {
        pointFirst += BONUS_POINT;
        return "Player 1: " + pointFirst + "." + " Player 2: " + pointSecond;
    } else if (tanksKilledFirstPlayer < tanksKilledSecondPlayer) {
        pointSecond += BONUS_POINT;
        return "Player 1: " + pointFirst + "." + " Player 2: " + pointSecond;
    } else {
        return "Player 1: " + pointFirst + "." + " Player 2: " + pointSecond;
    }
}

?

static int getTotalDamage(int damage, String typeMob, boolean hasHolyAttribute) {
    double damageCoefficient;
    switch (typeMob) {
        case "UNDEAD":
        case "ZOMBIE":
            damageCoefficient = 1.5;
            break;
        case "SAINT":
            damageCoefficient = 0.5;
            break;
        case "ANIMAL":
        case "HUMANOID":
        case "PLANT":
        case "GHOST":
            damageCoefficient = 1;
            break;
        default: return 0;
        }
        if (hasHolyAttribute == true) {
            return  (int) Math.round(damage * damageCoefficient);
        } else {
           return damage;
        }
}

?

static int getNumberStation(int firstFuelReserves, int secondFuelReserves, int thirdFuelReserves) {
    if (firstFuelReserves < secondFuelReserves) {
        if (firstFuelReserves < thirdFuelReserves || firstFuelReserves == thirdFuelReserves) {
            return 1;
        } else {
            return 3;
        }
    } else if (firstFuelReserves == secondFuelReserves) {
        if (thirdFuelReserves < firstFuelReserves) {
            return 3;
        } else {
            return 1;
        }
    } else if (secondFuelReserves < thirdFuelReserves || secondFuelReserves == thirdFuelReserves) {
        return 2;
    } else {
        return 3;
    }
}

?

static boolean isLeapYear(int year) {
    //TODO
    // Код, решающий задачу пишем ниже, при этом используя параметры метода
    return LocalDate.of(year, 1, 1).isLeapYear();
}